Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev fix #4277

Closed
wants to merge 2 commits into from
Closed

Dev fix #4277

wants to merge 2 commits into from

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented Nov 8, 2023

🤖 Generated by Copilot at 5d35709

Summary

🗑️🛠️🍴

This pull request removes the bytebase provider and the db-bytebase controller from the sealos project. It updates the GitHub workflows, the Makefiles, and the dependency files to exclude the bytebase-related code and images. It also moves the db-bytebase controller code to a separate fork under the labring namespace.

We're cleaning up the sealos code, me hearties
We're dropping bytebase from the project
So heave away and pull the ropes together
We'll make the sealos sail faster and better

Walkthrough

  • Remove the bytebase provider from the sealos project by deleting or updating the references to it in the following files and directories:
  • ./.github/workflows/controllers.yml (link, link)
  • ./.github/workflows/frontend.yml (link, link)
  • ./frontend/Makefile (link)
  • ./frontend/pnpm-lock.yaml (link)
  • ./go.work (link)
  • ./controllers/db/bytebase (link-link)
  • Move the bytebase provider to a separate fork for experimental purposes by adding the labring fork as a dependency in the ./go.work file (link) and renaming the ./controllers/db/bytebase directory to ./staging/src/github.com/labring/controllers/db/bytebase (link-link)
  • Fix a typo in the image-build and image-push targets in the ./frontend/Makefile file by removing a trailing space after the $* variable (link)

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 981
✅ Successful 312
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 668
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@zzjin zzjin closed this Nov 8, 2023
Copy link

sweep-ai bot commented Nov 8, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants