Merge pull request #1808 from MaoShizhong/fix/unify-body-query-serial…

…isation-behaviour fix: unify body and query serialisation behaviour
ladjs · Aug 24, 2024 · bfb2d00 · bfb2d00
2 parents 072d898 + bef7b08
commit bfb2d00
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/client.js b/src/client.js
@@ -192,7 +192,9 @@ request.types = {
  */
 
 request.serialize = {
-  'application/x-www-form-urlencoded': qs.stringify,
+  'application/x-www-form-urlencoded': (obj) => {
+    return qs.stringify(obj, { indices: false, strictNullHandling: true });
+  },
   'application/json': safeStringify
 };
 

diff --git a/src/node/index.js b/src/node/index.js
@@ -99,7 +99,9 @@ exports.protocols = {
  */
 
 exports.serialize = {
-  'application/x-www-form-urlencoded': qs.stringify,
+  'application/x-www-form-urlencoded': (obj) => {
+    return qs.stringify(obj, { indices: false, strictNullHandling: true });
+  },
   'application/json': safeStringify
 };
 

diff --git a/test/client/serialize.js b/test/client/serialize.js
@@ -38,6 +38,7 @@ describe('request.serializeObject()', () => {
     serialize({ '&name&': 'tj' }, '%26name%26=tj');
     serialize({ hello: '`test`' }, 'hello=%60test%60');
     serialize({ $hello: 'test' }, '$hello=test');
+    serialize({ foo: 'foo', foo: 'bar' }, 'foo=foo&foo=bar');
   });
 });