Skip to content

Commit

Permalink
fix(extensionutil): Ensure that ShadeMesh extension properties are added
Browse files Browse the repository at this point in the history
  • Loading branch information
chriswmackey authored and Chris Mackey committed Nov 17, 2023
1 parent 6978ebf commit b82e817
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion honeybee/dictutil.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def dict_to_object(honeybee_dict, raise_exception=True):
Args:
honeybee_dict: A dictionary of any Honeybee object. Note
that this should be a non-abridged dictionary to be valid.
raise_exception: Boolean to note whether an excpetion should be raised
raise_exception: Boolean to note whether an exception should be raised
if the object is not identified as a part of honeybee.
Default: True.
Expand Down
4 changes: 3 additions & 1 deletion honeybee/extensionutil.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def model_extension_dicts(data, extension_key, room_ext_dicts, face_ext_dicts,
align with the serialized model.faces.
- shade_ext_dicts: A list of Shade extension property dictionaries that
align with the serialized model.shades.
align with the serialized model.shades plus the model.shade_meshes.
- aperture_ext_dicts: A list of Aperture extension property dictionaries that
align with the serialized model.apertures.
Expand Down Expand Up @@ -52,6 +52,8 @@ def model_extension_dicts(data, extension_key, room_ext_dicts, face_ext_dicts,
shade_ext_dicts)
if 'orphaned_shades' in data and data['orphaned_shades'] is not None:
shade_extension_dicts(data['orphaned_shades'], extension_key, shade_ext_dicts)
if 'shade_meshes' in data and data['shade_meshes'] is not None:
shade_extension_dicts(data['shade_meshes'], extension_key, shade_ext_dicts)

return room_ext_dicts, face_ext_dicts, shade_ext_dicts, \
aperture_ext_dicts, door_ext_dicts
Expand Down

0 comments on commit b82e817

Please sign in to comment.