Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role needs to be updated to latest NetBox #132

Open
lae opened this issue Jul 7, 2021 · 6 comments · Fixed by #141
Open

Role needs to be updated to latest NetBox #132

lae opened this issue Jul 7, 2021 · 6 comments · Fixed by #141

Comments

@lae
Copy link
Owner

lae commented Jul 7, 2021

Hey guys. I haven't managed to proactively keep this role in sync with upstream (living circumstances over the past year and a half haven't been very conducive to many activities), so I could use some help if anyone's willing to pitch in.

Basically, the major version release notes and all minor version update notes for NetBox need to be reviewed and then this role needs to be updated to support new features or use updated configurations, etc. Some changes that might affect earlier versions negatively may need to be version-gated, as well.

This should be done separately for the latest 2.10 and latest 2.11 releases. Refer to the following PRs for examples of how it's been done in the past.

Please feel free to open a PR like this to keep track of your work if you'd like to work on this. I'd greatly appreciate it. Whenever possible, I'll try to provide my own code reviews as well.

In the worst case that this isn't able to be completed sooner, I'll probably be able to focus more on this hopefully by the end of the year.

@Dzordzu
Copy link

Dzordzu commented Sep 6, 2021

I can confirm that role (as of now) works perfectly for 2.10 and 2.11 (I'm currently using netbox 2.11.11)
But now 3.0.1 is present, so it may break

@lae
Copy link
Owner Author

lae commented Sep 6, 2021

I'm not too surprised that it works as-is for later versions, but if there were new features introduced they might need configuration support within the role.

@smutel
Copy link
Contributor

smutel commented Dec 16, 2021

Hello,

I am interesting to help you on this topic to be able to install Netbox 3 with your role.
Perhaps it's possible to create several issues with a tag "netbox_3.0" for example.
It will be easy after to create MR for each issue.

What do you think ?

Regards,

@TheMonkeyBrain
Copy link

Just did an update from Netbox v2.11.11 to v3.1.9 by using the changes in PR #134 and #136 and didn't run into any issues.

@lae lae closed this as completed in #141 Mar 29, 2022
@lae lae reopened this Mar 29, 2022
@tyler-8
Copy link
Collaborator

tyler-8 commented Apr 20, 2022

I did an upgrade from 2.10.10 to 3.1.11 using #141 and it went smoothly.

@MozeBaltyk
Copy link

Guy may I suggest to add to the readme as prequisite to make this role work ? (for those who use ansible-core)

ansible-galaxy collection install community.postgresql   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants