Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update netbox version to 3.0.7 #134

Closed
wants to merge 4 commits into from
Closed

Update netbox version to 3.0.7 #134

wants to merge 4 commits into from

Conversation

rsp2k
Copy link

@rsp2k rsp2k commented Oct 9, 2021

No description provided.

@lae
Copy link
Owner

lae commented Oct 9, 2021

Hi. Thanks for your PR.

Have you gotten a chance to review #132 and if so, can you confirm that you've read through the changelogs for NetBox up until the current release to ensure that any new configuration changes/features are accounted for in this changeset?

@rsp2k
Copy link
Author

rsp2k commented Oct 10, 2021

I've gone through the changelogs, the only thing I found is a new daily "housekeeping" cron job that I've added to my fork.

Add cronjob and bump stable version
@lae
Copy link
Owner

lae commented Oct 10, 2021

So I quickly tried to validate for myself and read through the changes from 2.9.9 to 2.10.10 (so there might still be stuff missing for 2.11.x and 3.0.x), and found these two that affect this role:
netbox-community/netbox#5938 (which we already have an issue for, #127, and I guess #125 is also of concern)
netbox-community/netbox#6083 (see associated PR for details)

I also realised I could quickly do a diff on some files to help pinpoint configuration changes and upgrade.sh changes from 2.9.9 to current:

https://gist.github.com/lae/a24a0bc366e76626ff65f48c9ed32319

On a quick skim most of the config file changes look superficial and so the only thing that could probably use an update is the example at examples/netbox_config.yml. The redis change (the second PR mentioned above) is done in the config template/with role variables. One of the upgrade changes already has a PR at #124 that I guess I need to go back to later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants