Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run Amplify on PRs from forks #196

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

lae
Copy link
Owner

@lae lae commented Dec 3, 2024

GitHub does not mint OIDC tokens for externally sourced PRs so this workflow can't successfully run. An alternative solution (like via an approval comment?) should be identified and implemented eventually to allow the workflow for previous contributors using their own forks.

Copy link
Contributor

amplify-security bot commented Dec 3, 2024

🔍 Amplify code check status:   status looks good

⚠️ 0 issues detected in   📄 1 file and   ❇️ 4 lines of code   🛠️ using Semgrep

Last updated by commit d217ed6 at 2024-12-03 22:52:31 UTC.

GitHub does not mint OIDC tokens for externally sourced PRs so this
workflow can't successfully run. An alternative solution (like via an
approval comment?) should be identified and implemented eventually to
allow the workflow for previous contributors using their own forks.

This also updates the workflow to run on the develop branch.
@lae lae force-pushed the fix/no-amplify-on-forks branch from c5a76b6 to d217ed6 Compare December 3, 2024 22:50
@lae lae changed the title [actions] don't run Amplify on PRs from forks Don't run Amplify on PRs from forks Dec 3, 2024
@lae lae merged commit 33a4aca into develop Dec 3, 2024
1 check passed
@lae lae deleted the fix/no-amplify-on-forks branch December 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant