Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid allocation when converting to axum's Response #467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid allocation when converting to axum's Response #467

wants to merge 1 commit into from

Conversation

dpc
Copy link

@dpc dpc commented Jan 20, 2025

I have not bother benchmarking, but I believe avoiding allocating a HashMap will be easier to optimize and/or faster at runtime.

@dpc
Copy link
Author

dpc commented Jan 20, 2025

Wait a moment. The .0 there is pre-escaped, no? Doesn't this require some ... rendering step? I'm probably missing something, but just wondering. BTw. Thanks for maud, I really enjoy using it.

nubunto
nubunto approved these changes Jan 24, 2025
View reviewed changes
Copy link

@nubunto nubunto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nubunto nubunto nubunto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpc @nubunto