feat(core): all-around tx check in assertoor #1259
Open
+84
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-o
changed the title
rodrigo-o
commented
Nov 25, 2024
| run_block_proposal_check: false | ||
| run_blob_transaction_test: true | ||
| tests: | ||
| - 'https://raw.githubusercontent.com/lambdaclass/ethrex/refs/heads/assertoor-allaround-tx-check/test_data/assertoor/el-stability-check.yml' |
There was a problem hiding this comment.
After review and before merging assertoor-allaround-tx-check will be replaced by main.
rodrigo-o
commented
Nov 25, 2024
| run_block_proposal_check: false | ||
| run_transaction_test: true | ||
| tests: | ||
| - 'https://raw.githubusercontent.com/lambdaclass/ethrex/refs/heads/assertoor-allaround-tx-check/test_data/assertoor/el-stability-check.yml' |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to have more checks regarding transactions, this PR accomplish that through assertoor
Description
This PR tackles 2 main things:
run_transaction_testcheck to the assertoor suite to not just validate blob transactions.To do it I separated the
network_params.yamlused for themake localnetfrom 2 new ones used just for the assertoor workflow, one for the blobs + stability check and the other for the tx + stability check. Also at the end of the stability check we make sure at least one block is proposed by us with more than 50tx (which happens after 1 epoch and the reorg/fork check). The separations was done due to time, it wasn't possible to parallelize the test as far as i checked without creating a new playbook and I preferred to use the already provided in parallel steps.Apart from creating the 2 new files, I removed assertoor from the one used by
make localnet.TIME
Right now every job (which run in parallel) takes ~15min, and added to the ~6min for the build it accounts to ~21min. This is, right now after the parallelization in the cancun engine hive test, the longest workflow in the CI.
Closes #1128