Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(l2): forbid panics #1367

Merged
merged 3 commits into from
Dec 3, 2024
Merged

refactor(l2): forbid panics #1367

merged 3 commits into from
Dec 3, 2024

Conversation

fborello-lambda
Copy link
Contributor

Motivation

There are some panic!s left, and we want to avoid using it in the future.

Description

  • Use the clippy.lint panic = "deny"
  • Remove panic! statements

Closes #1269

@fborello-lambda fborello-lambda self-assigned this Dec 2, 2024
@fborello-lambda fborello-lambda marked this pull request as ready for review December 2, 2024 14:57
@fborello-lambda fborello-lambda requested a review from a team as a code owner December 2, 2024 14:57
ilitteri
ilitteri approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilitteri ilitteri added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 94df083 Dec 3, 2024
17 checks passed
@ilitteri ilitteri deleted the l2/forbid_panics branch December 3, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri approved these changes

Assignees

@fborello-lambda fborello-lambda

Labels
L2
Projects
ethrex_l2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

L2: Forbid panics
2 participants
@fborello-lambda @ilitteri