Stark continuous read-only memory example #940
+481
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #940 +/- ##
==========================================
+ Coverage 70.99% 71.04% +0.05%
==========================================
Files 153 153
Lines 32770 32770
==========================================
+ Hits 23264 23283 +19
+ Misses 9506 9487 -19 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pablodeymo
reviewed
Nov 15, 2024
| // (a'_{i+1} - a'_i)(a'_{i+1} - a'_i - 1) = 0 where a' is the sorted address | ||
| let res = (a_sorted1 - a_sorted0) * (a_sorted1 - a_sorted0 - FieldElement::<F>::one()); | ||
|
|
||
| transition_evaluations[self.constraint_idx()] = res; |
There was a problem hiding this comment.
you should check if the vector can hold the value at that position
|
|
||
| let mut aux_col = Vec::new(); | ||
| let num = z - (&a[0] + alpha * &v[0]); | ||
| let den = z - (&a_sorted[0] + alpha * &v_sorted[0]); |
There was a problem hiding this comment.
For learning purposes this is ok, but for performance reasons, it's best to compute all the denominators, due batch inverse and then compute
diegokingston
approved these changes
Nov 25, 2024
pablodeymo
reviewed
Nov 25, 2024
| } | ||
| } | ||
|
|
||
| #[derive(Clone)] |
There was a problem hiding this comment.
this annotation should be placed after the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Stark example for continuous read-only memory constraints
Checklist