Gh 894 power ups #899
Merged
Gh 894 power ups #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rease logic there
manucamejo
previously approved these changes
Sep 9, 2024
Nico-Sanchez
requested changes
Sep 9, 2024
apps/arena/lib/arena/game_updater.ex
Outdated
Comment on lines
1507
to
1509
| unless Crate.alive?(crate) do | ||
| send(self(), {:crate_destroyed, attacking_player.id, crate.id}) | ||
| end |
There was a problem hiding this comment.
This is done in multiple places. We should isolate this behavior to update every destroyed crate state in a single pass in only one place.
There was a problem hiding this comment.
I isolated this send behavior inside of the take_damage/3
Nico-Sanchez
previously approved these changes
Sep 9, 2024
Nico-Sanchez
previously approved these changes
Sep 9, 2024
AminArria
reviewed
Sep 9, 2024
apps/arena/lib/arena/game/effect.ex
Outdated
| Entities.take_damage(entity, real_damage) | ||
| |> maybe_send_to_killfeed(pool_owner.id) | ||
| if Entities.alive?(entity) do | ||
| Entities.take_damage(entity, real_damage, pool_owner.id) |
There was a problem hiding this comment.
Do you think it makes sense to move Entities.alive?/1 check to be inside of Entities.take_damage/3?
There was a problem hiding this comment.
it totally does! i just did it
agustinesco
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
agustinesco
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
agustinesco
temporarily deployed
to
testing-chile
GitHub Actions
Inactive
Nico-Sanchez
approved these changes
Sep 9, 2024
manucamejo
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Redesign the way we acquire power ups through the game.
There's an existing bug where you get extra power up from crates if you hit it with two projectiles that will be fixed in #904
Closes #894
Summary of changes
How to test it?
Test the game in this branch and instead of the crates dropping the power ups to the ground you should see your power up number go up
Checklist