Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-974] Add bushes to merliot #979

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

tvillegas98
Copy link
Contributor

@tvillegas98 tvillegas98 commented Nov 7, 2024

Motivation

Add missing bushes to Merliot. to bring more Dynamism to matches
Closes #974

Summary of changes

I added a lot of new bushes. You’ll notice in the browser that some are circular while others are square, this was intentional because some bushes were harder to implement as circles than as squares.

Remember that these bushes are just approximations to what we what in our current map, we'll make it them more precise in further iterations, either by adding more bushes in the front or modify the backend

How to test it?

  • Run the seeds again by doing make start
  • Play the game either in the browser or unity client and check that new at least most of the bushes are cover correctly

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@tvillegas98 tvillegas98 marked this pull request as ready for review November 7, 2024 18:46
manucamejo
manucamejo previously approved these changes Nov 7, 2024
@manucamejo manucamejo merged commit 3127d1c into main Nov 8, 2024
2 checks passed
@manucamejo manucamejo deleted the gh-974-add-bushes-to-merliot branch November 8, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Add bushes to merliot
3 participants