Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sierra emu #55

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

sierra emu #55

wants to merge 3 commits into from

Conversation

edg-l
Copy link
Contributor

@edg-l edg-l commented Sep 18, 2024

No description provided.

@edg-l edg-l marked this pull request as ready for review September 19, 2024 10:27
azteca1998
azteca1998 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@azteca1998 azteca1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge it to our main? The branch is supposed to be only for debugging, no?

@FrancoGiachetta
Copy link
Contributor

I think we can close this PR. The sierra-emu has already been added in branch trace-dump-2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancoGiachetta FrancoGiachetta FrancoGiachetta approved these changes

@azteca1998 azteca1998 azteca1998 approved these changes

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@fmoletta fmoletta Awaiting requested review from fmoletta fmoletta is a code owner

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edg-l @FrancoGiachetta @azteca1998