Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eigen-client-m0-implementation): concurrent da dispatcher #333

Merged
merged 2 commits into from
Nov 12, 2024
Merged

feat(eigen-client-m0-implementation): concurrent da dispatcher #333

merged 2 commits into from
Nov 12, 2024

Conversation

juan518munoz
Copy link

What ❔

Implement concurrent data availability dispatcher, to greatly reduce dispersing time when there are many blobs due dispersing.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

gianbelinche
gianbelinche reviewed Nov 11, 2024
View reviewed changes
core/node/da_dispatcher/src/da_dispatcher.rs Outdated
Comment on lines 237 to 239
// TODO: this query might always return the same blob if the blob is not included
// we should probably change the query to return all blobs that are not included
let blob_info = conn
Copy link

@gianbelinche gianbelinche Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we address this TODO?

Copy link
Author

@juan518munoz juan518munoz Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, added it!

juanbono
juanbono approved these changes Nov 11, 2024
View reviewed changes
Copy link

@juanbono juanbono left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gianbelinche
gianbelinche approved these changes Nov 12, 2024
View reviewed changes
Copy link

@gianbelinche gianbelinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gianbelinche gianbelinche merged commit 64d0a38 into eigen-client-m0-implementation Nov 12, 2024
12 of 24 checks passed
@gianbelinche gianbelinche deleted the eigen-client-m0-concurrent-dispatcher branch November 12, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianbelinche gianbelinche gianbelinche approved these changes

@juanbono juanbono juanbono approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juan518munoz @juanbono @gianbelinche