Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eigen-client-extra-features): Remove kzgpad #339

Merged
merged 2 commits into from
Nov 15, 2024
Merged

feat(eigen-client-extra-features): Remove kzgpad #339

merged 2 commits into from
Nov 15, 2024

Conversation

gianbelinche
Copy link

What ❔

This PR removes kzgpad dependency.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

juanbono
juanbono requested changes Nov 15, 2024
View reviewed changes
Copy link

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test with an empty vec

@gianbelinche gianbelinche merged commit f2fb12c into eigen-client-extra-features Nov 15, 2024
12 of 24 checks passed
@gianbelinche gianbelinche deleted the eigen-client-remove-kzgpad branch November 15, 2024 21:19
@juanbono juanbono mentioned this pull request Nov 20, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan518munoz juan518munoz juan518munoz approved these changes

@juanbono juanbono juanbono approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gianbelinche @juanbono @juan518munoz