Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new GrowingFormFieldType TEXTAREA #9

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

caspahouzer
Copy link
Contributor

No description provided.

Copy link
Member

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change

index.js Outdated
@@ -524,6 +574,7 @@ class GrowingForm {

const GrowingFormFieldType = {
TEXT: 'text',
TEXTAREA: 'textarea',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camel case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified

Field types are superfluous, as they can be controlled via keyboardType.

Camel case textArea

Auto-focus next field via option focusNexField: true
@caspahouzer
Copy link
Contributor Author

README example updated

added 'return' listener for textfields for quicker input
@@ -524,8 +581,7 @@ class GrowingForm {

const GrowingFormFieldType = {
TEXT: 'text',
EMAIL: 'email',
NUMBER: 'number',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

textField.keyboardType = Ti.UI.KEYBOARD_TYPE_DEFAULT;
break;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore all references to existing field types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants