-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new GrowingFormFieldType TEXTAREA #9
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change
index.js
Outdated
@@ -524,6 +574,7 @@ class GrowingForm { | |||
|
|||
const GrowingFormFieldType = { | |||
TEXT: 'text', | |||
TEXTAREA: 'textarea', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
camel case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified
Field types are superfluous, as they can be controlled via keyboardType. Camel case textArea Auto-focus next field via option focusNexField: true
README example updated |
added 'return' listener for textfields for quicker input
@@ -524,8 +581,7 @@ class GrowingForm { | |||
|
|||
const GrowingFormFieldType = { | |||
TEXT: 'text', | |||
EMAIL: 'email', | |||
NUMBER: 'number', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed?
textField.keyboardType = Ti.UI.KEYBOARD_TYPE_DEFAULT; | ||
break; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore all references to existing field types
No description provided.