Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor DenyList filter #174

Merged
merged 1 commit into from
Sep 7, 2024
Merged

refactor DenyList filter #174

merged 1 commit into from
Sep 7, 2024

Conversation

pinclau
Copy link
Contributor

@pinclau pinclau commented Sep 7, 2024

Q A
BC Break yes
QA yes

Description

  • remove inheritage and implement FilterInterface
  • remove options getter and setter

Signed-off-by: Claudiu Pintiuta <[email protected]>
@Ocramius Ocramius self-assigned this Sep 7, 2024
@Ocramius Ocramius closed this Sep 7, 2024
@Ocramius Ocramius reopened this Sep 7, 2024
@Ocramius Ocramius added this to the 3.0.0 milestone Sep 7, 2024
@Ocramius
Copy link
Member

Ocramius commented Sep 7, 2024

Soz, fat-fingered that.

Thanks @cPintiuta!

@Ocramius Ocramius merged commit b076ac9 into laminas:3.0.x Sep 7, 2024
21 of 23 checks passed
gsteel added a commit to gsteel/laminas-filter that referenced this pull request Sep 8, 2024
This was referenced Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants