Refactor DashToSeparator Filter
#184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opening a Draft to seek feedback before I progress this any further. Could you let me know if this is broadly what you had in mind please? |
ramchale
commented
Oct 23, 2024
Signed-off-by: ramchale <[email protected]>
ramchale
force-pushed
the
DashToSeparator
branch
from
3336485 to
52e9f2d
Compare
ramchale
commented
Oct 23, 2024
gsteel
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Thanks @ramchale :)
Ideally, each filter refactor should be accompanied by changes to the docs too - Here's an example and a companion patch targeting the next 2.x minor with the relevant deprecations, like this one
- Use ScalarOrArrayFilterCallback::applyRecursively - Remove setSeparator and getSeparator - Add to migration doc - Update usage doc to remove construction without Options array Signed-off-by: ramchale <[email protected]>
|
Thanks. I've updated that in line with the suggestions, let me know if further changes are needed. I'll open a corresponding deprecation branch against the current minor branch when I get a little bit of time |
gsteel
requested changes
Oct 23, 2024
gsteel
changed the title
DashToSeparator Filter
Co-authored-by: George Steel <[email protected]> Signed-off-by: Richard McHale <[email protected]>
gsteel
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring DashToSeparator based on #177