Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SeparatorToSeparator Filter #193

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

ramchale
Copy link
Contributor

@ramchale ramchale commented Nov 5, 2024

Q A
Documentation yes
Bugfix no
BC Break yes
New Feature no
RFC no
QA no

Description

Refactor the following filters for #177

  • SeparatorToSeparator
  • DashToUnderscore
  • SeparatorToDash
  • UnderscoreToDash
  • UnderscoreToSeparator

@ramchale ramchale force-pushed the SeparatorToSeparator branch from 1a2b131 to c2de83e Compare November 5, 2024 17:29
@ramchale ramchale marked this pull request as ready for review November 5, 2024 17:30
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ramchale - Just a couple of things on the docs, otherwise LGTM 👍

docs/book/v3/word.md Outdated Show resolved Hide resolved
docs/book/v3/migration/v2-to-v3.md Show resolved Hide resolved
@gsteel gsteel mentioned this pull request Nov 6, 2024
54 tasks
@gsteel gsteel self-assigned this Nov 6, 2024
@gsteel gsteel added this to the 3.0.0 milestone Nov 6, 2024
@ramchale ramchale force-pushed the SeparatorToSeparator branch from c2de83e to b225a9b Compare November 6, 2024 13:58
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gsteel gsteel merged commit 25d0693 into laminas:3.0.x Nov 6, 2024
16 of 17 checks passed
gsteel added a commit to gsteel/laminas-filter that referenced this pull request Dec 17, 2024
gsteel added a commit to gsteel/laminas-filter that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants