✨ Extend schema json #961
✨ Extend schema json #961
Conversation
fredericenard
commented
Feb 4, 2025
•
fredericenard
commented
- We need a robust way to flag user defined link tables (see this slack thread + private discussion with @falexwolf)
- This discussion with @Zethson mades me realized some fields are missing in the schema json (primary key flag, maybe also the field used for default ordering and title displayed in the UI).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
==========================================
- Coverage 83.99% 83.96% -0.03%
==========================================
Files 43 43
Lines 3536 3549 +13
==========================================
+ Hits 2970 2980 +10
- Misses 566 569 +3 ☔ View full report in Codecov by Sentry. |
| self.model = model | ||
| self.class_name = model.__name__ | ||
| self.module_name = module_name | ||
| self.model_name = model._meta.model_name | ||
| self.table_name = model._meta.db_table | ||
| self.included_modules = included_modules | ||
| self.fields = self._get_fields_metadata(self.model) | ||
| self.is_link_table = issubclass(model, LinkORM) |
There was a problem hiding this comment.
I thought we had this line already since the beginning. Good that we track this now!
|
Great! 😄 Can you please also add a test for a link table example? And: can we also track whether a field is |
