Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version with passport model added. #175

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

hannestschofenig
Copy link
Collaborator

@hannestschofenig hannestschofenig commented Dec 29, 2024

In this PR, I have added the long-awaited support for the passport model to the CSR attestation draft. While the functionality was implicitly present through the use of the conceptual message wrapper, the text previously lacked any explicit explanation.

I understand that introducing this functionality at this stage may seem late. However, I strongly believe we should not publish the draft without it, as there is significant industry interest in supporting both models: the background-check model and the passport model.

Copy link
Contributor

@ounsworth ounsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so you are defining a second pair of extensions / attributes for id-aa-ar that are basically the same but without the layer that allows bundles and certs. ARs must be signed, right? Is that true that ARs never need an external certificate chain? I understand that you don't need a SEQUENCE OF AR, but should there be a SEQUENCE OF CertificateChoices ?

I did not read all the new text, but I skimmed it and it seems good.

@hannestschofenig
Copy link
Collaborator Author

Two points in response, Mike:

  1. ASN.1 correctness: I’m not entirely sure about the validity of the included ASN.1. It seems we had a bug, which I noticed when extending it with this PR. We should review the ASN.1 carefully during an upcoming call.

  2. Attestation Results certificate chains: Because the standardization efforts for Attestation Results (ARs) are relatively recent, I assumed the AR structure can carry these chains. However, it’s worth verifying this assumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants