Add ASN.1 module #47
Closed
Add ASN.1 module #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danvangeest
added a commit
to lamps-wg/cms-kyber
that referenced
this pull request
Oct 11, 2024
Depends on lamps-wg/kyber-certificates#47 but that can happen in parallel.
|
I'm told by MikeO there's an issue with this, so I'll convert it to a draft for now. |
seanturner
reviewed
Oct 14, 2024
seanturner
reviewed
Oct 14, 2024
seanturner
reviewed
Oct 14, 2024
|
@danvangeest PTAL I edited my comments a couple of times and suggested something new for the proposed change. |
Co-authored-by: Sean Turner <[email protected]>
|
@seanturner your suggestions look good to me, though they're beyond the reach of my ASN.1 knowledge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.