Move examples #48
Merged
Move examples #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the examples to an Appendix.
bwesterb
approved these changes
Oct 15, 2024
|
This reminds me I can create those examples for you now. |
danvangeest
reviewed
Oct 16, 2024
| @@ -357,6 +305,9 @@ prior example, the textual encoding defined in {{RFC7468}} is used: | |||
| key pair and widest ability to import the key. | |||
| </aside> | |||
|
|
|||
| {example-private} contains an example of an id-alg-ml-kem-768 private key | |||
There was a problem hiding this comment.
Appendix says it's ML-KEM-512, here says 768. Which one? No actual examples to verify this against :)
| -----END PUBLIC KEY------- | ||
| ~~~ | ||
|
|
||
| {example-public} contains an example of an id-alg-ml-kem-768 public key |
There was a problem hiding this comment.
Appendix says it's ML-KEM-512, here says 768. Which one? No actual examples to verify this against :)
There was a problem hiding this comment.
Yep should be 768!
Co-authored-by: Daniel Van Geest <[email protected]>
Co-authored-by: Daniel Van Geest <[email protected]>
Co-authored-by: Daniel Van Geest <[email protected]>
seanturner
commented
Oct 18, 2024
seanturner
commented
Oct 18, 2024
seanturner
commented
Oct 18, 2024
seanturner
commented
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the examples to an Appendix.