Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak Key Encoding Text #52

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Tweak Key Encoding Text #52

merged 1 commit into from
Oct 21, 2024

Conversation

seanturner
Copy link
Collaborator

Tweaking the key encoding text to match text from other LAMP I-Ds.

@seanturner
Tweak Key Encoding Text
70ce429 
Tweaking the key encoding text to match text from other LAMP I-Ds.
danvangeest
danvangeest approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@danvangeest danvangeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very familiar with this text so of course I'd approve it.

@bwesterb
Copy link
Collaborator

Given WG consensus to use seed as private key, we should change the text here to say the private key is the seed. I can write some text if you'd like.

@seanturner
Copy link
Collaborator Author

@bwesterb please suggest some text. Also, take a look at #51 to make sure it lands in the right place.

@seanturner seanturner merged commit daa4c09 into main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danvangeest danvangeest danvangeest approved these changes

@bwesterb bwesterb bwesterb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanturner @bwesterb @danvangeest