Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pin-draining function to device specific file #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmoskal
Copy link
Contributor

@mmoskal mmoskal commented Jan 18, 2017

This isn't the cleanest, but slightly better than current

@jamesadevine
Copy link
Collaborator

@mmoskal makes sense - however i'm not keen on the use of _pin which is an mbed specific internal type. Perhaps an accessor would be better incase we moved away from mbed in the future? Something like getPinName()?

@mmoskal
Copy link
Contributor Author

mmoskal commented Jan 18, 2017

Sure, but this PR doesn't do it, it was already there - I'm only using pinID which is a number

@finneyj
Copy link
Collaborator

finneyj commented Jan 18, 2017

yup - thanks @mmoskal. Better than where it was for sure - I squeezed this in for Peli last night and didn't think anyone would notice until I had chance to move. i should have known your eagle eyes would pick it up. :-)

I was thinking we'd end up with a platform specific implementation of the Pin class (one per platform), and we can drop it in there along with getDigitalValue() etc. as chargePin() drainPin() etc. etc.

@pelikhan
Copy link
Contributor

@finneyj What's the status on this PR?

microbit-carlos pushed a commit to microbit-carlos/codal that referenced this pull request Jan 20, 2023
…date-mb-build-instructions

Update mb build instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants