Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ninja as the build system if available (not only on Windows). #96

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Use Ninja as the build system if available (not only on Windows). #96

merged 1 commit into from
Jan 17, 2025

Conversation

microbit-carlos
Copy link
Collaborator

For example, in my Macbook Ninja is still 30% faster than using Make, so it'd be great to use Ninja by default if available.

@microbit-carlos microbit-carlos mentioned this pull request Jan 17, 2025
Open
microbit-carlos
microbit-carlos commented Jan 17, 2025
View reviewed changes
Copy link
Collaborator Author

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was reviewed in call on the 17th of December and ready to be merged.
Also raised in upstream CODAL:

@microbit-carlos microbit-carlos merged commit 696b461 into master Jan 17, 2025
27 checks passed
@microbit-carlos microbit-carlos deleted the use-ninja-if-available branch January 17, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@microbit-carlos