standard-tests: Fix ToolsIntegrationTests to correctly handle "content_and_artifact" tools #29391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
🤖:bug
…t_and_artifact" tools The response from tool.invoke is always a ToolMessage, with content and artifact fields, not a tuple. Add a test that now passes.
rectalogic
force-pushed
the
content_and_artifact
branch
from
62b3da8 to
7d67464
Compare
|
@efriis could you take a look at this when you get a chance? Currently |
ccurme
approved these changes
Feb 6, 2025
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The response from
tool.invoke()is always a ToolMessage, with content and artifact fields, not a tuple.The tuple is converted to a ToolMessage here
langchain/libs/core/langchain_core/tools/base.py
Line 726 in b6ae7ca
Issue:
Currently
ToolsIntegrationTestsrequiresinvoke()to return a tuple and so standard tests fail for "content_and_artifact" tools. This fixes that to check the returned ToolMessage.This PR also adds a test that now passes.