Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[minor]: 04 - Refactoring PDFMiner parser #29526

Merged
merged 4 commits into from
Feb 6, 2025
Merged

community[minor]: 04 - Refactoring PDFMiner parser #29526

merged 4 commits into from
Feb 6, 2025

Conversation

pprados
Copy link
Contributor

@pprados pprados commented Jan 31, 2025 •
edited
Loading

This is one part of a larger Pull Request (PR) that is too large to be submitted all at once. This specific part focuses on updating the PDFMiner parser.

For more details, see PR 28970.

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 5:51pm

@pprados pprados mentioned this pull request Jan 31, 2025
Draft
2 tasks
@pprados pprados changed the title community[minor]: 03 - Refactoring PDFMiner parser community[minor]: 04 - Refactoring PDFMiner parser Jan 31, 2025
@pprados pprados force-pushed the pprados/04-pdfminer branch 4 times, most recently from 278c6d2 to b14176c Compare January 31, 2025 16:02
@pprados pprados marked this pull request as ready for review January 31, 2025 16:27
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 31, 2025
@pprados
Copy link
Contributor Author

pprados commented Jan 31, 2025

@eyurtsev
The next one ;-)

@dosubot dosubot bot added community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) labels Jan 31, 2025
@pprados pprados marked this pull request as draft January 31, 2025 16:43
@pprados pprados marked this pull request as ready for review January 31, 2025 16:46
@eyurtsev eyurtsev self-assigned this Jan 31, 2025
@eyurtsev
Copy link
Collaborator

need to resolve: #29470 to make sure this and other loaders aren't affected

@pprados
Refactor pdfminer
db29855 
Fix PyMuPDFLoader
@pprados pprados force-pushed the pprados/04-pdfminer branch from ee61770 to db29855 Compare February 3, 2025 10:06
@pprados
Copy link
Contributor Author

pprados commented Feb 5, 2025 •
edited
Loading

@eyurtsev
I resolved the bug 29478 here and simultaneously in this PR.

I wait the validation.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 5, 2025
@eyurtsev eyurtsev merged commit 6ff0d5c into langchain-ai:master Feb 6, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees

@eyurtsev eyurtsev

Labels
community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
PR Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pprados @eyurtsev