Performance improvements in core library #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nfcampos
commented
Sep 11, 2024
nfcampos
commented
- Avoid creating new callback manager when received one as arg
- Avoid looking for config when already received one as arg
- Avoid copies of values in ensure_config/merge_configs
- Implement version of ensure_config that accepts multiple configs (avoids calling merge_configs first)
- Avoid calling merge_configs when we only need to attach extra tags/metadata
hinthornw
reviewed
Sep 11, 2024
| @@ -46,6 +46,8 @@ | |||
| from langgraph.pregel.types import All, PregelExecutableTask, PregelTask | |||
| from langgraph.utils.config import merge_configs, patch_config | |||
|
|
|||
| EMPTY_SEQ = tuple() | |||
There was a problem hiding this comment.
Do you have an idea of how helpful this was? I guess this is sort of an inner loop
There was a problem hiding this comment.
This was more because the previous code was actually incorrect, as it could end up trying to do <str> in None
hinthornw
reviewed
Sep 11, 2024
| checkpoint["channel_versions"][chan] = get_next_version( | ||
| max_version, channels[chan] | ||
| ) | ||
| if channels[chan].consume() and get_next_version is not None: |
There was a problem hiding this comment.
is this just stylistic or does it actually improve perf?
There was a problem hiding this comment.
No this was just style
hinthornw
reviewed
Sep 11, 2024
| @@ -97,6 +97,9 @@ def __radd__(self, other: dict[str, Any]) -> "AddableUpdatesDict": | |||
| raise TypeError("AddableUpdatesDict does not support right-side addition") | |||
|
|
|||
|
|
|||
| EMPTY_SEQ = tuple() | |||
There was a problem hiding this comment.
Should we just make a single empty_seq in an internal _constants file or something
hinthornw
approved these changes
Sep 11, 2024
- Avoid creating new callback manager when received one as arg - Avoid looking for config when already received one as arg - Avoid copies of values in ensure_config/merge_configs - Implement version of ensure_config that accepts multiple configs (avoids calling merge_configs first) - Avoid calling merge_configs when we only need to attach extra tags/metadata
nfcampos
force-pushed
the
nc/11sep/perf
branch
from
620a82b to
2ddcce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.