checkpoint postgres: allow passing custom serde #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vermapratyush thank you for your contribution -- it's okay to pass custom serde, but the metadata serializer should remain jsonplus. could you please make the changes accordingly? |
vermapratyush
force-pushed
the
serde-postgres-checkpoint
branch
from
2c32498 to
7be933f
Compare
nfcampos
reviewed
Sep 12, 2024
vbarda
changed the title
vermapratyush
force-pushed
the
serde-postgres-checkpoint
branch
from
4720c98 to
fa9009a
Compare
nfcampos
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance AsyncPostgresSaver.from_conn_string constructor method to accept custom jsonserializer.