Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update name to InMemorySaver #2044

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update name to InMemorySaver #2044

wants to merge 2 commits into from

Conversation

hinthornw
Copy link
Contributor

(Keep MemorySaver around for backwards compatibility)

"MemorySaver" is ambiguous: is it saving memories? Where is it saving memories to?

InMemorySaver aligns naming InMemoryStore as well as similar LangChain objects (InMemoryVectorStore, etc.)

vbarda
vbarda approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@vbarda vbarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, i do think this is a better name. need to update reference docs

@eyurtsev
Copy link
Contributor

InMemorySaver is much better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbarda vbarda vbarda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hinthornw @eyurtsev @vbarda