Relax BasePostgresSaver _search_where assumption (implements discussion 2396) #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…should be ignored
…ery and should be ignored" This reverts commit 3c557e6.
|
Sorry for the reverted commit - this was a misconception on my part. Empty strings are to be expected for the checkpoint_ns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the assumptions of the _search_where() function of the BasePostgresSaver class such that a thread_id is no longer required. This enables searches like "Show me all checkpoints with a given user_id in the metadata", which would have an empty configurable and only rely on filters.
Implements discussion #2396.