Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollback for aio setup #2681

Closed
wants to merge 2 commits into from

Conversation

jcampbell
Copy link

ROLLBACK AND CHAIN if the checkpoint migrations table is missing.

I observed the current rollback attempt not to work on an uninitialized data source, because the transaction is left in an error state by the aio carry forward of the standard saver.

ROLLBACK AND CHAIN if the checkpoint migrations table is missing.
@hinthornw
Copy link
Contributor

Do you have a code snippet of how you're using the setup that makes this necessary?

@jcampbell
Copy link
Author

Thanks for the follow up. In looking at the docs more closely to confirm that I hadn't missed something, I realized of course that I had: the checkpointer assumes psycopg is set to autocommit. With autocommit, this is not needed; I'll close the PR.

@jcampbell jcampbell closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants