patch(langgraph): Refactor pregel loop to use new PregelRunner class, ported from python LangGraph.
#791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamincburns
force-pushed
the
ben/pregel-runner
branch
7 times, most recently
from
1144241 to
8dda05d
Compare
benjamincburns
force-pushed
the
ben/pregel-runner
branch
from
8dda05d to
261cef4
Compare
nfcampos
reviewed
Jan 21, 2025
| console.log( | ||
| `Retrying task "${pregelTask.name}" after ${interval.toFixed( | ||
| `Retrying task "${String(pregelTask.name)}" after ${interval.toFixed( |
There was a problem hiding this comment.
this doesn't do anything, right? string interpolation does calls toString on things anyway
There was a problem hiding this comment.
Not sure how that snuck in - probably an errant Cursor [tab] edit 🤔.
There was a problem hiding this comment.
Ah right, it's necessary because the type of pregelTask.name is string | Symbol.
nfcampos
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is a prerequisite to porting the imperative (functional?) API over from python LangGraph.