should still batch undefined values and try to evaluate them. (not pe…

…rfect: #2)
lapwinglabs · Jan 23, 2015 · d8f679e · d8f679e
1 parent f5b5e8f
commit d8f679e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/object.js b/lib/object.js
@@ -51,7 +51,6 @@ function _batch() {
     var values = {};
     var errors = {};
     keys(expected).forEach(function(key) {
-      if (undefined === actual[key]) return;
       batch.push(function(next) {
         expected[key](actual[key], function(err, val) {
           if (err) {

diff --git a/test/index.js b/test/index.js
@@ -330,6 +330,19 @@ describe('Rube', function() {
         });
       })
 
+      // it('should throw because it\'s missing an attribute', function(done) {
+      //   var schema = Rube({
+      //     a: Rube(String),
+      //     b: Rube(String),
+      //     c: Rube(String)
+      //   }).or('a', 'b');
+
+      //   schema.only('c')({}, function(err, v) {
+      //     assert(err);
+      //     done();
+      //   });
+      // })
+
     });
 
     describe('.only(str)', function() {