Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asserting responses are ok before asserting presence of components #337

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

da-mask
Copy link
Contributor

@da-mask da-mask commented Dec 6, 2023

assertOK() should be made before assertSeeVolt() and other assertions. If response is not ok and assertOK is not first, it can be difficult to debug (this has bitten me before).

@taylorotwell taylorotwell merged commit a1a373c into laravel:1.x Dec 6, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants