Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Bumps friendsofphp/php-cs-fixer #232

Closed
wants to merge 1 commit into from

Conversation

nunomaduro
Copy link
Member

This pull request is a work in progress, and it Bumps friendsofphp/php-cs-fixer to the latest version. However, seems that the following case is not working as expected. So, need to double check this first:

➜ pint -v

  ............!.....................................

  ──────────────────────────────────────────────────────────────────── Laravel
    FAIL   ................................................. 50 files, 1 error
  ! app/Models/User.php Parse error: syntax error, unexpected identifier "FOOO
     12▕ {
     13▕
     14▕     use HasApiTokens, HasFactory, Notifiable;
     15▕
  ➜  16▕     const string FOOO = 'qwdqw';

@Jubeki
Copy link
Contributor

Jubeki commented Jan 8, 2024

@nunomaduro maybe it is time to bump dependencies for pint again?

Also please be aware of the following after bumping, which will result in failing tests, due to changes in the rule fully_qualified_strict_types do you want a PR with these changes to the skeleton?
https://github.com/Jubeki/laravel-code-style/actions/runs/7441521104/job/20243723598

@nunomaduro
Copy link
Member Author

@Jubeki Are you able to provide a pull request, against this branch, and makes the new update not causing changes on the skeleton?

@Jubeki
Copy link
Contributor

Jubeki commented Jan 8, 2024

@nunomaduro I don't think so, because I think the rule is not configurable in that way. But I would need to make sure (probably tomorrow I can check that)

@nunomaduro nunomaduro closed this Jan 9, 2024
@nunomaduro nunomaduro deleted the feat/phpcs-fixer-3-40 branch January 9, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants