added stopwords cleaner with tests #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an interesting addition! For applications that match text this looks very useful. Thank you. The build fails with a compile error: /home/travis/build/larsga/Duke/duke-core/src/main/java/no/priv/garshol/duke/cleaners/StopwordsCleaner.java:[49,21] error: cannot find symbol Looks like you're using a newer Java version. Please fix that. Also, please remove the .idea folder from the PR. I'll go through the code and comment on that now. |
| j | ||
| just | ||
| k | ||
| keep keeps |
|
Okay, I will update this. |
|
Thank you! That's much appreciated. I hope you agree with the comments. If not, just let me know. |
|
Larsga, I have updated every point except for -
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.