Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol editable now in configuration of dynamic sitemap initializer #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abdurrehmanamjad
Copy link

user can specify the protocol http/https by assigning it in initialiser. e.g. config.protocol = "https"

@mclark4386
Copy link

mclark4386 commented Sep 14, 2016

For the record it looks like that failed because of the test config not because of the change to the code... @lassebunk any ideas?

I think this is a super important patch because it would fix at least 3 of your currently opened issues as well as my current issue with the lib.

Update

I actually fixed it by pulling from github instead of letting it pull the standard gem, but you probably still need to double check the testing script^^;

@abdurrehmanamjad
Copy link
Author

@mclark4386 Thanks for the appreciation, can you please educate me why is it failing for Ruby 1.9.3 in travis-ci for installation of different gems?

The error is same while bundle install with Ruby 1.9.3 in Travis:

Installing safe_yaml 1.0.4
NoMethodError: undefined method spec' for nil:NilClass Installing tzinfo 0.3.51 An error occurred while installing dynamic_sitemaps (2.0.0), and Bundler cannot continue. Make sure thatgem install dynamic_sitemaps -v '2.0.0'` succeeds before
bundling.
The command "eval bundle install --jobs=3 --retry=3" failed. Retrying, 2 of 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants