Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh1519 docu fix #1651

Merged
merged 8 commits into from
Feb 5, 2025
Merged

Gh1519 docu fix #1651

merged 8 commits into from
Feb 5, 2025

Conversation

FrankMittelbach
Copy link
Member

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • [n/a] Test file(s) added
  • Version and date string updated in changed source files
  • [n/a] Relevant \changes entries in source included
  • Relevant changes.txt updated
  • [n/a] Rollback provided (if necessary)?
  • [] ltnewsX.tex (and/or latexchanges.tex) updated

Copy link
Contributor

@muzimuzhi muzimuzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor typos.

FrankMittelbach and others added 2 commits February 3, 2025 15:06
Co-authored-by: Yukai Chou <[email protected]>
Co-authored-by: Yukai Chou <[email protected]>
@FrankMittelbach
Copy link
Member Author

Two minor typos.

Only two? that's an improvement. But let's wait until @car222222 wakes up

Copy link
Contributor

@car222222 car222222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, and one query.

@car222222
Copy link
Contributor

Not sure that I am fully awake, but . . .

@mrpiggi
Copy link

mrpiggi commented Feb 4, 2025

Since it looks like you are correcting changes.txt in several places, searching for a simple regex like \\[^\{\n]+\{.*$ maybe would help to find some additional entries left over from C&P. There are obviously at least two more or less complete entries from \changes in 1998 ;)

@FrankMittelbach FrankMittelbach merged commit baa5656 into develop Feb 5, 2025
86 checks passed
@FrankMittelbach FrankMittelbach deleted the gh1519 branch February 5, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants