-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagging of section numbers #1661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this gives a much better reading.
With Lbl
, section headings are announced twice: a heading like "2 Introduction" read as "section heading level 1, 2; section heading level 1, introduction".
With Span
it is read as "section heading level 1, 2 introduction"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with some queries and some textual suggestions
required/latex-lab/latex-lab-sec.dtx
Outdated
@@ -651,6 +662,7 @@ | |||
\MakeLinkTarget#1{#2} | |||
} | |||
} | |||
\AddToNoCaseChangeList{\@hyp@section@target@n} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought: I don't know how long this no case change list already is, but wouldn't it be faster (and perhaps even better readable, if there is a general purpose \donotchangecase{...} with one argument that is used around material that should not change case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean \NoCaseChange
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could instead put everywhere \NoCaseChange around the command if that is is faster, not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it probably is faster as it has no effect on MakeUppercase in general whereas adding to the list means that every use of MakeUppercase has to check for \@hyp@section@target@n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need more speed, I an always rework how \AddToNoCaseChangeList
works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I meant that, I wasn't sure that surived in the final implementation. My guess is that it would be faster and and also clearer codewise. what's your option @josephwright ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need more speed, I an always rework how
\AddToNoCaseChangeList
works
maybe, but I don't see that it helps to have a long list if the task is always identical and understandably covered by a single command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched to NoCaseChange
section-number
role-mapped to Span as this gives a better reading experience:Internal housekeeping
Checklist of required changes before merge will be approved
\changes
entries in source includedchanges.txt
updatedltnewsX.tex
(and/orlatexchanges.tex
) updated