Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for #1675 #1676

Merged
merged 6 commits into from
Mar 1, 2025
Merged

fix for #1675 #1676

merged 6 commits into from
Mar 1, 2025

Conversation

FrankMittelbach
Copy link
Member

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • Rollback provided (if necessary)?
  • [n/a] ltnewsX.tex (and/or latexchanges.tex) updated - don't think this is necessary

mbertucci47
mbertucci47 reviewed Feb 26, 2025
View reviewed changes
mbertucci47
mbertucci47 reviewed Feb 26, 2025
View reviewed changes
davidcarlisle
davidcarlisle approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@davidcarlisle davidcarlisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine should there be a combined ltnews entry for this and the amsmath change?

car222222
car222222 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@car222222 car222222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@FrankMittelbach
Copy link
Member Author

Code looks fine should there be a combined ltnews entry for this and the amsmath change?

maybe I wasn't sure what to write ... care to suggest/add one to the pr?

muzimuzhi
muzimuzhi reviewed Feb 28, 2025
View reviewed changes
@FrankMittelbach
Copy link
Member Author

Code looks fine should there be a combined ltnews entry for this and the amsmath change?

maybe I wasn't sure what to write ... care to suggest/add one to the pr?

I added one (or rather two) for this and #1673. Please have a look @davidcarlisle

muzimuzhi
muzimuzhi reviewed Mar 1, 2025
View reviewed changes
@FrankMittelbach FrankMittelbach merged commit 40cfaf2 into develop Mar 1, 2025
87 checks passed
@FrankMittelbach FrankMittelbach deleted the gh1675 branch March 1, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muzimuzhi muzimuzhi muzimuzhi approved these changes

@mbertucci47 mbertucci47 mbertucci47 left review comments

@josephwright josephwright josephwright approved these changes

@davidcarlisle davidcarlisle davidcarlisle approved these changes

@u-fischer u-fischer u-fischer approved these changes

@car222222 car222222 car222222 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@FrankMittelbach @josephwright @davidcarlisle @u-fischer @muzimuzhi @car222222 @mbertucci47