-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build error and add enhancements #2
Conversation
Test commit Update README and LaTeX build configuration with correct repository name Update README.md Test commit Update README and LaTeX build configuration with correct repository name update .gitignore
add main branch to ci.yml add main branch to ci.yml Update README.md and tests Revert "Update README and LaTeX build configuration with correct repository name" This reverts commit b8d6caf. Update README and LaTeX build configuration with correct repository name Update update.yml Update README.md Update README and LaTeX build configuration with correct repository name Update update.yml Update README and LaTeX build configuration with correct repository name Update update.yml no additional '/workflows/CI' at the end Update update.yml to change project name in CMakeLists.txt Update update.yml to change project name in CMakeLists.txt Update README and LaTeX build configuration with correct repository name Update update.yml Update update.yml Update update.yml Update README and LaTeX build configuration with correct repository name Update README and LaTeX build configuration with correct repository name Update update.yml Update README.md Update README and LaTeX build configuration with correct repository name Update update.yml Update README and LaTeX build configuration with correct repository name Update update.yml no additional '/workflows/CI' at the end
add issues url add condition to check for setissueslinkurl cmd
Revert "Update README and LaTeX build configuration with correct repository name" This reverts commit 87b70c8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions! Just a few comments to be discussed
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
…sitory name" This reverts commit 139531a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts so far. Just a few more comments for the python code
I just did some tests with the new workflow. Everything seems to work. |
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good.
Another cool thing we could do is to create some unit tests for our Python script (can be a follow up PR, if you want). For this, I would recommend pytest and its fakefilesystem plugin. This makes it super easy to unit test file io operations without writing to the disk.
I tried to add the unit tests. The test now only fails for the CMakeLists.txt. I can look into that later, or maybe you also find the mistake until then. |
|
Still found some time. I think it's fixed now. |
.github/workflows/test_update.py.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge this into the ci.yml
. Let's put it between the checkout and the git add safe dir step.
Since it is super fast and we don't have that many changes, we don't need the extra path/changes logic.
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
I removed the hours and minutes from the Last revised because I think it is unnecessary and we have |
git config --global --add safe.directory $GITHUB_WORKSPACE
before the build allows cmake to write into 'git.id' and fixes the following build error:Suggestion: add a "Update README and LaTeX Build File" workflow to make using the template easier
Suggestion: add a hyperlink into every document that directly forwards the user to the repo's issues page. (For that also see my PR in latex4ei-packages here: Add issues hyperlink and fix CI latex4ei-packages#6)