-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latexdiff to artifacts #8
Conversation
🤖 The artifacts from this build are available here. |
🤖 The artifacts from this build are available here. |
This workflow change additionally runs latexdiff on the I also noticed that the pull request comment does not work with forks and added a "not-so-fancy" @hofbi Do you think we should just remove the "Comment on PR with artifact link" step or do you have any other suggestion? |
I am fine with removing the comment. It is more a convenience feature, the artifacts are still there. Regarding the latex diff, could you briefly explain the motivation for this? For the implementation, I noticed that you are now checking out the base branch. This seems a bit inefficient. I think GH actions provide a very efficient way to give you the actual diff of a PR. Maybe we can make use of this to prevent 2 checkouts. |
Alright, I will remove it. The latex diff should make it more convenient to review changes in a commit or pull request, by running I tested this for a current pr in Schaltungstechnik-1-2 and the output is this: Schaltungstechnik_diff.pdf I will try to find a more efficient way. But for running |
The new approach now only fetches from remote and the files are copied over individually in the |
No description provided.