Skip to content

Commit

Permalink
update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
holic committed Aug 14, 2024
1 parent dec7d2f commit 43dba06
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion packages/world-module-metadata/test/MetadataModule.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ contract MetadataModuleTest is Test, GasReporter {
world.installModule(metadataModule, new bytes(0));

// Transferring the namespace to the module and installing should be a no-op/idempotent and the module will return namespace ownership.
// TODO: is this a security concern? could someone frontrun by putting a tx in between the two calls below?
world.transferOwnership(namespace, address(metadataModule));
world.installModule(metadataModule, new bytes(0));
assertEq(NamespaceOwner.get(namespace), address(this));
Expand Down
1 change: 1 addition & 0 deletions packages/world-module-metadata/ts/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { worldgen } from "@latticexyz/world/node";
*/

// TODO: move tablegen/worldgen to CLI commands from store/world we can run in package.json instead of a custom script
// (https://github.com/latticexyz/mud/issues/3030)

const __dirname = path.dirname(fileURLToPath(import.meta.url));
const configPath = "../mud.config";
Expand Down

0 comments on commit 43dba06

Please sign in to comment.