-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add benchmark GitHub workflow #2234
Conversation
|
Is there a way for us to configure the benchmark suite to report absolute numbers instead of relative ones? ("x seconds" vs "x times faster than y") |
Also curious if you looked into actions like this one https://github.com/benchmark-action/github-action-benchmark that have built-in support for reporting the benchmark results to a github-pages branch |
My impression is that most Actions only support certain benchmark tools (ie. not Vitest/tinybench). However github-action-benchmark does mention some custom |
Ahh that's great. Somehow didn't find it in the action logs |
I had |
package.json
Outdated
@@ -10,6 +10,7 @@ | |||
"scripts": { | |||
"all-codegen": "for dir in packages/store packages/world packages/world-modules packages/cli e2e/packages/contracts examples/*/packages/contracts templates/*/packages/contracts; do (cd \"$dir\" && pwd && pnpm build); done", | |||
"all-install": "for dir in . docs e2e examples/* templates/*; do (cd \"$dir\" && pwd && pnpm install); done", | |||
"bench": "pnpm run --filter=store-sync bench", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we do pnpm run --recursive bench
, it'll only run packages in the workspace with the bench script
which means we won't have to remember to update this later if we add benchmarks to more packages
Adds a GitHub Action where we can run benchmarks on a remote machine and inspect the output.