Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(world): add validateNamespace helper #2894

Merged
merged 7 commits into from
Jun 6, 2024
Merged

refactor(world): add validateNamespace helper #2894

merged 7 commits into from
Jun 6, 2024

Conversation

yonadaaa
Copy link
Contributor

@yonadaaa yonadaaa commented Jun 5, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f7d2481

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yonadaaa yonadaaa marked this pull request as ready for review June 5, 2024 18:00
@yonadaaa yonadaaa requested a review from alvrs as a code owner June 5, 2024 18:00
@yonadaaa yonadaaa requested a review from holic June 5, 2024 18:00
@yonadaaa yonadaaa requested a review from holic June 6, 2024 14:34
holic
holic reviewed Jun 6, 2024
View reviewed changes
packages/world/ts/config/v2/worldWithShorthands.ts
@@ -54,7 +54,7 @@ export type validateNamespacesWithShorthands<namespaces, scope extends Scope = A
[namespace in keyof namespaces]: {
[key in keyof namespaces[namespace]]: key extends "tables"
? validateTablesWithShorthands<namespaces[namespace][key], scope>
: validateNamespaces<namespaces[namespace], scope>[key];
: validateNamespace<namespaces[namespace], scope>[key];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remember to add this to validateWorld too

Copy link
Contributor Author

@yonadaaa yonadaaa Jun 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do that in #2880

@yonadaaa yonadaaa merged commit e0c9eaa into main Jun 6, 2024
13 checks passed
@yonadaaa yonadaaa deleted the yonadaaa/validate-namespace branch June 6, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic approved these changes

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yonadaaa @holic