-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial system manifest #2923
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a918699
add metadata dir
holic 3d40857
generate system manifests
holic 9964cb1
system namespace and system ID
holic cf9c312
fixes
holic 1ca67c3
refactor
holic 78f48c0
configPath -> rootDir
holic 3f247e3
don't need these
holic 843a7a7
remove metadata dir from config for now
holic 851a4ac
switch other utils to use rootDir instead of configPath
holic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
{ | ||
"systems": [ | ||
{ | ||
"sourcePath": "src/systems/CustomErrorsSystem.sol", | ||
"namespace": "", | ||
"name": "CustomErrorsSystem", | ||
"systemId": "0x73790000000000000000000000000000437573746f6d4572726f727353797374" | ||
}, | ||
{ | ||
"sourcePath": "src/systems/LibWrapperSystem.sol", | ||
"namespace": "", | ||
"name": "LibWrapperSystem", | ||
"systemId": "0x737900000000000000000000000000004c69625772617070657253797374656d" | ||
}, | ||
{ | ||
"sourcePath": "src/systems/NumberListSystem.sol", | ||
"namespace": "", | ||
"name": "NumberListSystem", | ||
"systemId": "0x737900000000000000000000000000004e756d6265724c69737453797374656d" | ||
}, | ||
{ | ||
"sourcePath": "src/systems/NumberSystem.sol", | ||
"namespace": "", | ||
"name": "NumberSystem", | ||
"systemId": "0x737900000000000000000000000000004e756d62657253797374656d00000000" | ||
}, | ||
{ | ||
"sourcePath": "src/systems/VectorSystem.sol", | ||
"namespace": "", | ||
"name": "VectorSystem", | ||
"systemId": "0x73790000000000000000000000000000566563746f7253797374656d00000000" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"systems": [ | ||
{ | ||
"sourcePath": "src/systems/ChatSystem.sol", | ||
"namespace": "", | ||
"name": "ChatSystem", | ||
"systemId": "0x737900000000000000000000000000004368617453797374656d000000000000" | ||
}, | ||
{ | ||
"sourcePath": "src/systems/IncrementSystem.sol", | ||
"namespace": "", | ||
"name": "IncrementSystem", | ||
"systemId": "0x73790000000000000000000000000000696e6372656d656e7400000000000000" | ||
}, | ||
{ | ||
"sourcePath": "src/systems/InventorySystem.sol", | ||
"namespace": "", | ||
"name": "InventorySystem", | ||
"systemId": "0x73790000000000000000000000000000496e76656e746f727953797374656d00" | ||
}, | ||
{ | ||
"sourcePath": "src/systems/StructSystem.sol", | ||
"namespace": "", | ||
"name": "StructSystem", | ||
"systemId": "0x7379000000000000000000000000000053747275637453797374656d00000000" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
{ | ||
"systems": [ | ||
{ | ||
"sourcePath": "src/modules/init/RegistrationSystem.sol", | ||
"namespace": "world", | ||
"name": "RegistrationSystem", | ||
"systemId": "0x7379776f726c64000000000000000000526567697374726174696f6e53797374" | ||
}, | ||
{ | ||
"sourcePath": "src/modules/init/implementations/AccessManagementSystem.sol", | ||
"namespace": "world", | ||
"name": "AccessManagementSystem", | ||
"systemId": "0x7379776f726c640000000000000000004163636573734d616e6167656d656e74" | ||
}, | ||
{ | ||
"sourcePath": "src/modules/init/implementations/BalanceTransferSystem.sol", | ||
"namespace": "world", | ||
"name": "BalanceTransferSystem", | ||
"systemId": "0x7379776f726c6400000000000000000042616c616e63655472616e7366657253" | ||
}, | ||
{ | ||
"sourcePath": "src/modules/init/implementations/BatchCallSystem.sol", | ||
"namespace": "world", | ||
"name": "BatchCallSystem", | ||
"systemId": "0x7379776f726c64000000000000000000426174636843616c6c53797374656d00" | ||
}, | ||
{ | ||
"sourcePath": "src/modules/init/implementations/ModuleInstallationSystem.sol", | ||
"namespace": "world", | ||
"name": "ModuleInstallationSystem", | ||
"systemId": "0x7379776f726c640000000000000000004d6f64756c65496e7374616c6c617469" | ||
}, | ||
{ | ||
"sourcePath": "src/modules/init/implementations/WorldRegistrationSystem.sol", | ||
"namespace": "world", | ||
"name": "WorldRegistrationSystem", | ||
"systemId": "0x7379776f726c64000000000000000000576f726c64526567697374726174696f" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous
resolveWorldWithShorthands
code was always setting thenamespaces
key, which kept the downstreamresolveWorld
function from determining if we're using namespaces or not.This new logic conditionally sets the
namespaces
key only if it was already used.