-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: build step cleanup #2926
Conversation
|
import { glob } from "glob"; | ||
import { World } from "../config/v2/output"; | ||
|
||
export async function findSolidityFiles({ rootDir, config }: { rootDir: string; config: World }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surprised this hasn't come up before but downstream usages may need to exclude .t.sol
and .s.sol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah likely because we're all good about putting source in src
but technically possible to have test files, etc. live in this dir as well (and I personally like colocating tests with the files they're testing)
5fa86fb
to
4880cf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- let's add a changeset for the changed
build
cli command - let's also quickly update this in the docs for this command (just one line): https://mud.dev/cli/tablegen
- should we also change it for the
worldgen
command for consistency?
this doesn't change anything about the CLI commands (they still use worldgen hasn't been updated yet, will save this for when I start updating system interfaces |
pulled out of #2923
configPath
torootDir
everywhere, because we almost always want the project root dir and want to avoid usingpath.dirname
in all the downstream toolingmud build
commandall-codegen
toall-build
because that's actually what it's doing