Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(introduction): add video to the introduction 🚗 #2951

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Jul 16, 2024

No description provided.

@qbzzt qbzzt requested review from ludns, alvrs and holic as code owners July 16, 2024 21:01
Copy link

changeset-bot bot commented Jul 16, 2024

⚠️ No Changeset found

Latest commit: d8dfe7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@qbzzt qbzzt changed the title docs(introduction): add video to the introduction docs(introduction): add video to the introduction 🚗 Jul 16, 2024
docs/pages/introduction.mdx Outdated Show resolved Hide resolved
@alvrs
Copy link
Member

alvrs commented Aug 12, 2024

wonder if we should rather turn this into small video section (with thumbnails of each video) with a couple useful introductory videos. Two more i'd include:

@ludns
Copy link
Member

ludns commented Sep 11, 2024

Some of these videos are out of date (eg: config format is different). Is that a big deal?

@holic
Copy link
Member

holic commented Sep 11, 2024

still don't love that this takes over an existing, information-dense page

image

what about a sub-page under getting started or a separate videos page or section?

@qbzzt
Copy link
Contributor Author

qbzzt commented Sep 11, 2024

still don't love that this takes over an existing, information-dense page

It doesn't really take it over, but it does push it down. How about I resize the videos to make them smaller?

@qbzzt
Copy link
Contributor Author

qbzzt commented Sep 11, 2024

Some of these videos are out of date (eg: config format is different). Is that a big deal?

I don't think so because we state the date they were taken, and it's clear in a fast-moving industry that they might be inaccurate.

@holic
Copy link
Member

holic commented Sep 12, 2024

I feel pretty strongly we shouldn't clutter the Quickstart guide with these - they're not actually quick start videos.

And I agree that them being out of date doesn't help either. They would be more misleading and confusing than helpful in this context.

Can we make a separate videos section? Maybe as part of "Guides"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants